Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dan-starkware and @ShahakShama)

crates/starknet_client/resources/reader/block_post_0_13_2.json line 1 at r1 (raw file):

{

IDK how to review this file, so I'm relying on your test making use of it and that's it...

Code quote:

{

crates/starknet_client/src/reader/objects/block_test.rs line 159 at r1 (raw file):

    );

    // TODO(shahak): Find a block with at least 2 transactions, and uncomment the code below.

What is the blocker for this? Why not do it now?

Code quote:

    // TODO(shahak): Find a block with at least 2 transactions, and uncomment the code below.

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @dan-starkware and @matan-starkware)

crates/starknet_client/src/reader/objects/block_test.rs line 159 at r1 (raw file):

Done

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dan-starkware and @ShahakShama)

crates/starknet_client/src/reader/objects/block_test.rs line 175 at r3 (raw file):

            }
        )
    );

It looks like you don't care about any of the fields, so why not remove this clutter?

(for the entire test)

Suggestion:

    assert_matches!(
        err,
        ReaderClientError::TransactionReceiptsError(
_        )
    );

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dan-starkware and @matan-starkware)

crates/starknet_client/src/reader/objects/block_test.rs line 175 at r3 (raw file):

Done.

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @dan-starkware and @ShahakShama)

crates/starknet_client/src/reader/objects/block_test.rs line 175 at r3 (raw file):

I left comments on the other places "(for the entire test)"

crates/starknet_client/src/reader/objects/block_test.rs line 126 at r4 (raw file):

                num_of_receipts: _,
            }
        )

Suggestion:

        ReaderClientError::TransactionReceiptsError(
_
        )

crates/starknet_client/src/reader/objects/block_test.rs line 141 at r4 (raw file):

                receipt_tx_index: _,
            }
        )

Suggestion:

        ReaderClientError::TransactionReceiptsError(
_
        )

crates/starknet_client/src/reader/objects/block_test.rs line 156 at r4 (raw file):

                receipt_tx_hash: _,
            }
        )

Suggestion:

        ReaderClientError::TransactionReceiptsError(
_
        )

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @dan-starkware and @matan-starkware)

crates/starknet_client/src/reader/objects/block_test.rs line 126 at r4 (raw file):

                num_of_receipts: _,
            }
        )

Done.

crates/starknet_client/src/reader/objects/block_test.rs line 141 at r4 (raw file):

                receipt_tx_index: _,
            }
        )

Done.

crates/starknet_client/src/reader/objects/block_test.rs line 156 at r4 (raw file):

                receipt_tx_hash: _,
            }
        )

Done.